fix: instrument bare catch blocks — logger.error sur stream/admin/user

This commit is contained in:
2026-03-15 00:18:37 +01:00
parent 494206b5b3
commit f80b8cb81c
3 changed files with 76 additions and 60 deletions

View File

@@ -3,6 +3,7 @@ import { AppDataSource } from "../config/data-source";
import { User } from "../entities/User"; import { User } from "../entities/User";
import { UserRole } from "../entities/UserRole"; import { UserRole } from "../entities/UserRole";
import { AuthenticatedRequest } from "./auth.middleware"; import { AuthenticatedRequest } from "./auth.middleware";
import logger from "../utils/logger";
/** /**
* Middleware requireAdmin — s'exécute APRÈS requireAuth. * Middleware requireAdmin — s'exécute APRÈS requireAuth.
@@ -39,7 +40,8 @@ export const requireAdmin = async (
} }
next(); next();
} catch { } catch (err) {
logger.error("requireAdmin — DB error", { err });
res.status(500).json({ success: false, error: "INTERNAL_ERROR" }); res.status(500).json({ success: false, error: "INTERNAL_ERROR" });
} }
}; };

View File

@@ -5,6 +5,7 @@ import { AppDataSource } from "../config/data-source";
import { Video } from "../entities/Video"; import { Video } from "../entities/Video";
import { User } from "../entities/User"; import { User } from "../entities/User";
import { UserSubscription } from "../entities/UserSubscription"; import { UserSubscription } from "../entities/UserSubscription";
import logger from "../utils/logger";
const router = Router(); const router = Router();
@@ -41,7 +42,8 @@ async function getUserLevel(token: string | undefined): Promise<number> {
}); });
return sub?.plan.level ?? 0; return sub?.plan.level ?? 0;
} catch { } catch (err) {
logger.warn("getUserLevel — auth/DB error", { err });
return 0; return 0;
} }
} }
@@ -128,7 +130,8 @@ router.get("/:key(*)", async (req: Request, res: Response): Promise<void> => {
}); });
fs.createReadStream(resolved).pipe(res); fs.createReadStream(resolved).pipe(res);
} }
} catch { } catch (err) {
logger.error("GET /stream/:key — unexpected error", { err });
res.status(500).json({ success: false, error: "INTERNAL_ERROR" }); res.status(500).json({ success: false, error: "INTERNAL_ERROR" });
} }
}); });

View File

@@ -3,6 +3,7 @@ import { AppDataSource } from "../config/data-source";
import { User } from "../entities/User"; import { User } from "../entities/User";
import { UserSubscription } from "../entities/UserSubscription"; import { UserSubscription } from "../entities/UserSubscription";
import { requireAuth, AuthenticatedRequest } from "../middleware/auth.middleware"; import { requireAuth, AuthenticatedRequest } from "../middleware/auth.middleware";
import logger from "../utils/logger";
const router = Router(); const router = Router();
@@ -27,6 +28,7 @@ async function getActiveSub(userId: string) {
router.get("/me/profile", requireAuth, async (req: Request, res: Response): Promise<void> => { router.get("/me/profile", requireAuth, async (req: Request, res: Response): Promise<void> => {
const { user } = req as AuthenticatedRequest; const { user } = req as AuthenticatedRequest;
try {
const localUser = await AppDataSource.getRepository(User).findOne({ const localUser = await AppDataSource.getRepository(User).findOne({
where: { superOAuthId: user.id }, where: { superOAuthId: user.id },
relations: ["userRoles", "userRoles.role"], relations: ["userRoles", "userRoles.role"],
@@ -66,6 +68,10 @@ router.get("/me/profile", requireAuth, async (req: Request, res: Response): Prom
createdAt: localUser.createdAt.toISOString(), createdAt: localUser.createdAt.toISOString(),
}, },
}); });
} catch (err) {
logger.error("GET /users/me/profile — DB error", { err });
res.status(500).json({ success: false, error: "INTERNAL_ERROR" });
}
}); });
/** /**
@@ -95,12 +101,13 @@ router.patch("/me", requireAuth, async (req: Request, res: Response): Promise<vo
if (!["http:", "https:"].includes(parsed.protocol)) { if (!["http:", "https:"].includes(parsed.protocol)) {
throw new Error("invalid protocol"); throw new Error("invalid protocol");
} }
} catch { } catch (_err) {
res.status(400).json({ success: false, error: "INVALID_AVATAR", message: "avatar must be a valid http/https URL or null" }); res.status(400).json({ success: false, error: "INVALID_AVATAR", message: "avatar must be a valid http/https URL or null" });
return; return;
} }
} }
try {
const userRepo = AppDataSource.getRepository(User); const userRepo = AppDataSource.getRepository(User);
const localUser = await userRepo.findOne({ where: { superOAuthId: user.id } }); const localUser = await userRepo.findOne({ where: { superOAuthId: user.id } });
@@ -122,6 +129,10 @@ router.patch("/me", requireAuth, async (req: Request, res: Response): Promise<vo
avatar: localUser.avatar, avatar: localUser.avatar,
}, },
}); });
} catch (err) {
logger.error("PATCH /users/me — DB error", { err });
res.status(500).json({ success: false, error: "INTERNAL_ERROR" });
}
}); });
export default router; export default router;